[ 
https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905444#action_12905444
 ] 

Tiago R. Espinha commented on DERBY-4757:
-----------------------------------------

I can. Maybe I should have put another comment there.

That change isn't actually necessary per se, the only thing is, by setting that 
argument to true, in case the client can't convert the string using the current 
CCSID manager, then it won't try to send it to the server. What the code inside 
that function does is, it tries to convert the string and if we get an 
exception, then we catch it and add it to the NetAgent. At a later point we can 
choose to do something wise with that exception.

If the argument is set to false, it will effectively try to send the RDBNAM to 
the server and it will still throw an exception but we don't catch it. We just 
let it break as the client will still not be able to encode the string.

So this is more of just making sure that we don't even try to send an RDBNAM at 
ACCSEC if we can't convert it. This is fine for newer clients, as they don't 
expect RDBNAM at ACCSEC to be required and older clients will break, but then 
again, if we can't send RDBNAM at ACCSEC to an older client, it means it has 
UTF-8 characters and then it is supposed to break. If the RDBNAM does not have 
UTF-8 characters, then the encoding process will go fine and old and new 
clients will work perfectly.

> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_donotcommit.diff, DERBY-4757_p1.diff, 
> DERBY-4757_p2.diff, DERBY-4757_p3.diff
>
>
> This issue is DERBY-4746's counterpart for the client changes required to 
> implement UTF8 support in DRDA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to