On 7/10/13 12:56 PM, msrecko...@mozilla.com wrote:
Why not?
Because submitting a first patch is scary enough as it is that we should try to minimize the roadblocks involved in it.
This is also why the reviewer in cases like that should handle setting the checkin-needed keyword (or just land the patch), push it to try as needed, etc.
If there is a list of good patch practices, there is no reason we can't ask people to complete a checklist and comment on it.
I think that's a fine thing to do for people who are planning to do more than one patch, and is definitely something we should do when someone starts contributing somewhat consistently. But I'm not convinced that it's reasonable to require it for a first patch...
-Boris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
