On 18/07/13 12:00, Gregory Szorc wrote: > Since new Makefile.in badness makes people's lives harder (especially > when it makes the build slower), I would like to propose a more strict > policy around Makefile.in changes: *if a non-list change in a > Makefile.in isn't reviewed by a build peer, it doesn't land or gets > backed out.* This could potentially be enforced with repository push hooks.
It is about time we added something like: $ mach commit-check tip In this case checking the r= in the commit comment would work. It could easily be extended to pick up other obvious mistakes like adding lines with white space at the end. We could run it before doing a bzexport. Anthony _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
