On Wednesday 2014-06-04 14:10 -0400, Boris Zbarsky wrote: > For example, should mochitest-plain be consistent with > mochitest-chrome? I would argue yes; the distinction between which > tests go in which one is more or less arbitrarily decided by what > APIs we do or don't have on SpecialPowers. > > Maybe the right answer is that pure-JS tests like xpcshell and > mochitest-browser should be consistent and combined JS-and-markup > tests like mochitest-plain and mochitest-chrome should (separately) > be consistent but we shouldn't worry about consistency between the > two groups of tests? > > I would very much welcome us actually having this discussion and > deciding _this_ point first, before we start deciding which APIs > should be deprecated and which should be preferred in which test > harness.
I strongly agree here about wanting consistency between mochitest-plain and mochitest-chrome because the distinction between them is very small. As a somewhat unusually but actually probably not all that extreme example, when writing content/canvas/test/test_drawWindow.html, I realized most of the way through writing the test -- i.e., when figuring out why the test I'd written didn't show the without-patch failures that were expected -- that half of the test needed to move to mochitest-chrome. So there are now two files, one in mochitest-plain and the other (content/canvas/test/chrome/test_drawWindow_widget_layers.html) in mochitest-chrome that share between them a common JS file containing the actual test assertions. (I believe I didn't want to move the whole test, because, if my memory is correct (I'm writing this offline), we run mochitest-chrome on fewer platforms than mochitest-plain.) -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla https://www.mozilla.org/ 𝄂 Before I built a wall I'd ask to know What I was walling in or walling out, And to whom I was like to give offense. - Robert Frost, Mending Wall (1914)
signature.asc
Description: Digital signature
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
