On 4/21/2015 1:11 PM, Andrew Halberstadt wrote:
On 21/04/15 03:02 PM, Aaron Klotz wrote:
On 4/21/2015 12:50 PM, Andrew Halberstadt wrote:
This could be effective, but if not implemented with care it could
also be very de-motivating, especially for a well-intentioned
contributor.
Is this really an issue though, given the time and effort required to
earn sufficient commit access to push to inbound?
It's the patch author that is on the hook for bustage, not the pusher.
Any contributor can land a patch on inbound by setting
'checkin-needed' on the bug.
I don't think there is an official policy on this, but I won't land a
patch on behalf of a contributor without either building it myself or a
green try push. IIRC I have been asked by the sheriffs to provide a try
push if I've requested a push via flagging checkin-needed. I think that
it's only fair that when asking somebody else to use their creds to push
to inbound, patch authors should first do their best to demonstrate that
their patch builds. Do we need to (or should we) formalize this?
But contributors aside, it could be de-motivating for employees too.
If I break inbound, I already feel really bad about it.. no need to
rub it in my face :). If there are employees who are blatantly abusing
inbound and don't seem to care about other people's time, perhaps a
private e-mail to them and/or their manager would be a more
appropriate response.
Sure, a valid point. A public shaming is not necessary.
- Aaron
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
