On Thu, Mar 09, 2017 at 08:25:17PM -0800, zbranie...@mozilla.com wrote: > As others stated, the idea that patch cannot be altered after r+ has a > massive effect on productivity. I can't overstate how much it would impact > day-to-day work for engineers, and I don't really see an easy way out. > > Even if we added "approval to land with minor changes" there's a) no way to > distinguish minor fro major, and b) reviewers will either start using it as a > default, or keep forgetting about it. > > I like the direction, but I honestly believe that this single idea would make > working with Gecko a massive PITA. > With autoland my path to central from when I get all the required reviews is > already ~24h because I push the "land" button around 2pm PST and it gets > merged into central around 3am, so I can only follow-up the next day. > > I recently introduced a regression not caught by me, my reviewer or tests. It > wasn't major enough to warrant panic mode, but I'm sure it irritated people > with spawned warnings and of course it has some impact on our nightly users. > I landed the follow up within 20 minutes of discovering the bug, but since it > wen't through autoland, it took two nightly builds and a full day before > users stopped reporting dups of the bug. > > Now, if you add to that, that every minor change I make after my reviewer > approved my patch I need to get a re-review (and most of my reviewers are in > a different timezone), it'll basically at the very best add just another 24h > to the cycle. > If it's Friday, or my reviewer is busy with other stuff or on PTO, it'll add > a couple days.
While we're talking about drag on productivity, there's already one that comes from autoland already, which is that you can't easily land fixups for stupid mistakes (like, a build failure on one platform, or other lame things that happen when things land). You either have to get a sheriff to land the fixup for you on autoland, or to back you out, in which case you're back to square one and need to reland the whole thing. If on top of that, you also need another round of reviews... Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
