On Thu, Jan 3, 2019 at 8:43 AM Brian Grinstead <bgrinst...@mozilla.com> wrote:
> Artifact builds don’t work with PGO, do they? When I do `-p all` on an > artifact try push I get busted PGO builds (for example: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f8ead55ca97821c60ef38af4dec01b8bff0fdf3&selectedJob=219655864). > What's needed to make it work? Requiring a full build for frontend-only > changes would increase the turnaround time and resource savings in (3). > I can partly address this. There are two things at play (at least): 1) automation builds need a special configuration piece in place to properly support artifact builds. Almost certainly that's not in place for PGO builds, since it's such an unusual thing to do: "you want to pack PGO binaries into a development build... why?" But there's really no reason we can't do that in automation so I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=15175323 for these things. It's not high priority but we might as well capture the request; in general, we always want try pushes to succeed with sensible results if we can arrange it. 2) locally, we need to teach the artifact code to sniff whatever mozconfig options say "I'm doing PGO" and fetch the right binaries based on that. I think that enabling PGO locally is a little delicate, and I know that chmanchester (and others?) is working hard to make this more robust, so perhaps this is easy or becomes easy soon. I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1517532 to track this. If I'm wrong about the feasibility of these things, please update the tickets! Best, Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
