On Tue, Mar 12, 2019 at 3:55 AM Sylvestre Ledru <sylves...@mozilla.com> wrote:
> With this change, we are going to extend Bugzilla to add a new field with > three new values: > > - > > Defect - an issue in one of our products > - > > Enhancement - a new feature or an improvement > - > > Task - a developer task. For example: refactor code foo. > > Could please you explain more what these three values are supposed to represent, possibly with some examples? It feels like there's a lot of overlap between them. For instance, isn't any task I work on as a developer a developer task? Isn't refactoring both a task and an improvement (and thus also an enhancement)? Maybe the idea is something like: * Defect: the current implementation does not match the current intended behavior, and the former should be changed to match the latter. * Enhancement: the current intended behavior should be changed (and the implementation changed to match the new intended behavior). * Task: the current implementation should be changed, but the intended behavior remains the same. This breakdown is guided by what I remember of advice from I think David Baron on how to structure a review: you need to review what a patch intends to do (this being the "intended behavior" above), and also review whether the patch actually does what it intends to do (this being the "implementation" above). Maybe there's a better phrase than "intended behavior". Secondly, to bikeshed a little, could there be some name besides "task" for that third category? Like I said above, everything we work as developers is a developer task. "Refactor" seems like a clearer name, though maybe it is a little limiting. "Side grade"? :) Thirdly, what category should "organizational" bugs like meta bugs be assigned to? I guess if you have a meta bug for a bunch of enhancements, it would be an enhancement? 3) Adding a new field called “Regressed by” > This is great! The weird encoding of "regressed by" in the "depends on" field is one of the more confusing aspects of Bugzilla, given how important it is. I spend a ton of time setting regressions for bugs, and even still I have to stop occasionally to make sure I'm doing it the right way. Thanks, Andrew _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
