So, we're running out of frame state bits, and I think I need another one for the work I'm doing on the reflow branch. So what I'm thinking of doing is the following:
* create a virtual |GetClassBits| on nsIFrame for bits that are constant for a given frame type (if only C++ had |virtual PRUint32 classBits|!) * start by moving NS_FRAME_REPLACED_ELEMENT to it to get the one bit that I need (I think other things that could be part of this are the existing bits NS_FRAME_EXCLUDE_IGNORABLE_WHITESPACE, NS_FRAME_IS_BOX, and potentially NS_FRAME_REFLOW_ROOT if we changed which frame had that bit set for text inputs. A bunch of existing virtual functions, like IsContainingBlock, NeedsView, IsFloatContainingBlock, IsLeaf, and SupportsVisibilityHidden, could probably also be made part of this if we want to shrink vtables.) Does it seem OK to do this work on the reflow branch, or are other people likely to need bits before the reflow branch lands, which means I should do it to the trunk and then re-merge the reflow branch to a new branch off the trunk? -David -- L. David Baron <URL: http://dbaron.org/ > Technical Lead, Layout & CSS, Mozilla Corporation
pgpp0203wBOYY.pgp
Description: PGP signature
_______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
