On Monday 2006-06-05 13:55 -0500, Boris Zbarsky wrote:
> L. David Baron wrote:
> > * create a virtual |GetClassBits| on nsIFrame for bits that are
> >   constant for a given frame type (if only C++ had |virtual PRUint32
> >   classBits|!)
> >
> > * start by moving NS_FRAME_REPLACED_ELEMENT to it to get the one bit
> >   that I need
> 
> Isn't this basically what IsFrameOfType() is about?  That is, could we just 
> move NS_FRAME_REPLACED_ELEMENT into an IsFrameOfType() bit?

I took this approach.

Unfortunately it looks like all box-related frames other than menubar
should have had this bit set in the past; however, judging by what
happens with my IsFrameOfType implementation, they didn't.  I need to
figure out which of them, if any, actually had the bit set, and why the
code in ConstructXULFrame didn't do what it looks like it did.

-David

-- 
L. David Baron                                <URL: http://dbaron.org/ >
           Technical Lead, Layout & CSS, Mozilla Corporation

Attachment: pgp1k0UYVGG9u.pgp
Description: PGP signature

_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout

Reply via email to