L. David Baron wrote:
 * create a virtual |GetClassBits| on nsIFrame for bits that are
   constant for a given frame type (if only C++ had |virtual PRUint32
   classBits|!)

 * start by moving NS_FRAME_REPLACED_ELEMENT to it to get the one bit
   that I need

Isn't this basically what IsFrameOfType() is about? That is, could we just move NS_FRAME_REPLACED_ELEMENT into an IsFrameOfType() bit?

Does it seem OK to do this work on the reflow branch, or are other
people likely to need bits before the reflow branch lands, which means I
should do it to the trunk and then re-merge the reflow branch to a new
branch off the trunk?

I think it's pretty reasonable to add IsFrameOfType() bits on the reflow branch (but maybe that's because I've done just that for form controls. ;) ).

-Boris
_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout

Reply via email to