-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20180/#review39975
-----------------------------------------------------------



src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java
<https://reviews.apache.org/r/20180/#comment72758>

    This will create a file in HDFS because CachedConfiguration will include 
the HDFS conf files too, right? It would be good to note where the empty rfile 
will be created. Beware of multi-volume changes in the 1.6 merge too


- Josh Elser


On April 9, 2014, 9:28 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20180/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 9:28 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2654
>     https://issues.apache.org/jira/browse/ACCUMULO-2654
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Adds a simple utility for creating an empty RFile, leveraging existing code.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java 
> PRE-CREATION 
>   
> src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java
>  5374332 
> 
> Diff: https://reviews.apache.org/r/20180/diff/
> 
> 
> Testing
> -------
> 
> tested basic error handling and help messages. tested creating file on hdfs 
> and local file system. tested default codec, gz, and specifying the same 
> codec as default. Used PrintInfo to verify generated files.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Reply via email to