> On April 9, 2014, 9:42 p.m., Mike Drob wrote: > > Worth noting that in later version we switched away from commons-cli in > > favor of jcommander. > > > > Also, can you add a unit test? > > kturner wrote: > Since Accumulo does not normally create empty RFiles, its not a well > tested thing. The RFile unit test excercises creating an empty rfile and > seeking it. This ensures that an empty rfile is readable. I am wondering if > its worthwhile to have an IT that covers the use case this utility is > intended for. Could have an IT that offlines a table, replaces one of its > files with an empty rfile, onlines, and then scans. > > Sean Busbey wrote: > re: commons-cli v jcommander, I figured after merging forward I could > refactor it to match the system used in later versions. I figured it was > better not to introduce a new dep in the older branch. > > Sean Busbey wrote: > What would a unit test cover? I think Keith's idea of a IT is likely to > be more useful. > > Success criteria is scan completes with no errors? (i.e. does not check > the values actually returned)
yeah, thats what I was thinking. Success is Accumulo not blowing up when scanning an empty file. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review39938 ----------------------------------------------------------- On April 9, 2014, 9:28 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20180/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 9:28 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2654 > https://issues.apache.org/jira/browse/ACCUMULO-2654 > > > Repository: accumulo > > > Description > ------- > > Adds a simple utility for creating an empty RFile, leveraging existing code. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java > PRE-CREATION > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java > 5374332 > > Diff: https://reviews.apache.org/r/20180/diff/ > > > Testing > ------- > > tested basic error handling and help messages. tested creating file on hdfs > and local file system. tested default codec, gz, and specifying the same > codec as default. Used PrintInfo to verify generated files. > > > Thanks, > > Sean Busbey > >
