> On April 10, 2014, 2 a.m., Josh Elser wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > line 43 > > <https://reviews.apache.org/r/20180/diff/2/?file=554090#file554090line43> > > > > This will create a file in HDFS because CachedConfiguration will > > include the HDFS conf files too, right? It would be good to note where the > > empty rfile will be created. Beware of multi-volume changes in the 1.6 > > merge too > > Sean Busbey wrote: > CachedConfiguration is just about Hadoop configs, AFAICT. It behaves per > normal HDFS client rules: it uses the default filesystem if you don't give it > a full url. On most hdfs installs that's storing into HDFS. I also tested > making it with a local filesystem. > > Do you mean note like with a log message? > > I figured in 1.6, it's better to keep things simple and output with > normal HDFS apis. This will normally be used in response to an error and the > missing file will be in a particular HDFS instance.
I think the help message would be best. If I were using a tool, that'd be the first place I check for more information about what said tool is doing. - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review39975 ----------------------------------------------------------- On April 9, 2014, 9:28 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20180/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 9:28 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2654 > https://issues.apache.org/jira/browse/ACCUMULO-2654 > > > Repository: accumulo > > > Description > ------- > > Adds a simple utility for creating an empty RFile, leveraging existing code. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java > PRE-CREATION > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java > 5374332 > > Diff: https://reviews.apache.org/r/20180/diff/ > > > Testing > ------- > > tested basic error handling and help messages. tested creating file on hdfs > and local file system. tested default codec, gz, and specifying the same > codec as default. Used PrintInfo to verify generated files. > > > Thanks, > > Sean Busbey > >
