Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115288967
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java
---
@@ -17,10 +17,30 @@
*/
package org.apache.accumulo.core.file.blockfile.cache;
+import org.apache.accumulo.core.conf.AccumuloConfiguration;
+
/**
* Block cache interface.
*/
public interface BlockCache {
+
+ /**
+ * Start the block cache
+ *
+ * @param conf
+ * Accumulo configuration object
+ * @param maxSize
+ * maximum size of the on-heap cache
+ * @param blockSize
+ * size of the default RFile blocks
+ */
+ void start(AccumuloConfiguration conf, long maxSize, long blockSize)
throws Exception;
--- End diff --
re: POJO -> I was going to just use the AccumuloConfiguration and the
custom properties for this. I'm not sure how a single BlockCacheConfiguration
class would work across different BlockCache impls that have different
configuration parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
