Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115294926
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java
---
@@ -84,7 +85,7 @@
static final int statThreadPeriod = 60;
/** Concurrent map (the cache) */
- private final ConcurrentHashMap<String,CachedBlock> map;
--- End diff --
If have a CacheType, then could possibly deprecate the
`tserver.cache.data.size` type settings in favor of every implementation using
`general.custom.xyz.` settings. Or we could assume that every implementation
will at least want a max size and keep these settings around. I don't know
whats best.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
