Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115294680
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java
---
@@ -17,10 +17,30 @@
*/
package org.apache.accumulo.core.file.blockfile.cache;
+import org.apache.accumulo.core.conf.AccumuloConfiguration;
+
/**
* Block cache interface.
*/
public interface BlockCache {
+
+ /**
+ * Start the block cache
+ *
+ * @param conf
+ * Accumulo configuration object
+ * @param maxSize
+ * maximum size of the on-heap cache
+ * @param blockSize
+ * size of the default RFile blocks
+ */
+ void start(AccumuloConfiguration conf, long maxSize, long blockSize)
throws Exception;
--- End diff --
Hmm, yeah, I later realized most impls would find some way to piggy-back
properties into accumulo-site. Mostly, I figured that, eventually, we'd also
have other "universal" properties (max size and block size) that all of the
implementations would use.
Having some object there (or, using the Factory as Keith's suggestion
pushes towards) would at least avoid runtime issues (where the new Accumulo
expects a `start(AccumuloConfiguration, long, long, ...)` instead of just
`start(AccumuloConfiguration, long, long)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
