Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/253#discussion_r129917175
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
---
@@ -79,8 +80,15 @@ protected VolumeManagerImpl(Map<String,Volume> volumes,
Volume defaultVolume, Ac
this.volumesByFileSystemUri = HashMultimap.create();
invertVolumesByFileSystem(volumesByName, volumesByFileSystemUri);
ensureSyncIsEnabled();
- // Keep in sync with default type in the property definition.
- chooser = Property.createInstanceFromPropertyName(conf,
Property.GENERAL_VOLUME_CHOOSER, VolumeChooser.class, new
PerTableVolumeChooser());
+ // if they supplied a property and we cannot load it, then fail hard
+ try {
+ chooser = Property.createInstanceFromPropertyName(conf,
Property.GENERAL_VOLUME_CHOOSER, VolumeChooser.class, null);
+ } catch (NullPointerException npe) {
--- End diff --
Can this NPE check be consolidated with the null check later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
