Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/253#discussion_r129918169
--- Diff:
server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java
---
@@ -105,7 +115,8 @@ public String choose(VolumeChooserEnvironment env,
String[] options) {
@SuppressWarnings("deprecation")
private static final Property INSTANCE_DFS_URI =
Property.INSTANCE_DFS_URI;
- @Test
+ // Expected to throw a runtime exception when the WrongVolumeChooser
picks an invalid volume.
+ @Test(expected = RuntimeException.class)
--- End diff --
Using ExpectedException JUnit rule allows more fine checking of the thrown
exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
