My opinion isn't a principled one... it's a practical one. So, if it makes sense in some cases, certainly, create the separate issue. For example, it can be useful when you want to report an issue now, but don't have time to fix it right away. Or, if it's a complex issue that requires coordination to plan, to save work. Tracking issues for multiple PRs for different versions or subtasks are also useful separate from the PR.
What I've been annoyed by in the past is somebody creating an issue to fix a small typo (or other small issue) and then immediately creating a PR within 5 minutes. In such cases, they weren't created because discussion was needed; they were created merely to follow some prescribed workflow for its own sake. I just want to avoid people creating unnecessary work for those reviewers and release managers who spend all their time triaging and labeling issues, and to avoid unnecessary work for themselves and causing confusion for users when discussions are spread across multiple pages. So, sometimes it makes sense, but one shouldn't just create one out of habit, or because it is expected. They should do so, thoughtfully, for a specific and intentional reason. However, in this specific case, there's already an issue on JIRA, and the PR will create a second one. There's no need to create a third, especially for a trivial task such as creating unit tests for a few constructors. Also, keep in mind that discussion can occur on the mailing list for design and in the code review. GitHub also allows creating "Draft" PRs to mock up something quickly to facilitate discussion. In all cases, people should engage in an appropriate forum with intention, rather than merely following specific practices because they believe it to be expected by a predefined workflow. On Wed, Apr 17, 2019 at 10:26 AM Michael Wall <[email protected]> wrote: > > Hi Christopher, > > I'll disagree with you here. Going straight to a PR makes sense to me > sometimes, but not always. What is missing in the straight to PR model is > any discussion that would drive the development. A ticket could be used to > hash out details like assumptions or requirements or project design > preferences or historical approaches that have been tried before writing > any code. What I was trying to avoid is having a new contributor do work > to put up a PR only to have to go back and rework the solution when a > discussion in advance could have prevented that. Or even worse have the PR > rejected entirely for some reason. Maybe the idea is already implemented > and the contributor didn't see it in the code, or maybe the feature is out > of scope for the project or whatever. I don't see having an issue as > redundant but that is just my opinion. > > Mike > > On Wed, Apr 17, 2019 at 10:03 AM Christopher <[email protected]> wrote: > > > You don't need to create a new issue on GitHub. You can just create a > > Pull Request with the changes. PRs serve as their own issue. Creating > > an issue, and then creating a PR would be redundant. > > > > On Wed, Apr 17, 2019 at 9:45 AM Resnik, Donald J > > <[email protected]> wrote: > > > > > > Mike, > > > > > > Thanks, I will make the ticket in github and grab it. > > > > > > Don > > > ________________________________ > > > From: Michael Wall <[email protected]> > > > Sent: Wednesday, April 17, 2019 8:41 AM > > > To: dev > > > Subject: Re: new committer question > > > > > > [External Email] > > > > > > ---------------------------------------------------------------------- > > > Hi Don, > > > > > > As Christopher mentioned, we are not using JIRA for tracking issue > > > anymore. I would suggest creating a new issue on github with the info > > for > > > the ticket you want to work and maybe a link to the JIRA issue for > > > historical reference. Then make a comment on the JIRA ticket that links > > > the github issue. Discussion on the ticket can then happen on github and > > > if you create a PR you can link the github issue. > > > > > > Mike > > > > > > On Tue, Apr 16, 2019 at 8:47 PM Resnik, Donald J < > > > [email protected]> wrote: > > > > > > > Chris, > > > > > > > > Thanks for the email. I would be happy to take the ticket you > > suggested: > > > > > > > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ACCUMULO-2D4377&d=DwIFaQ&c=Ff2GokX4A_6S-cy_JRNEiQ&r=7sXp0We1OQQKRSGyjz35VSGU6op68dwzfY3c89DwDgBombhjVkfUnmcvB18wjBra&m=Z5TrAOFD4oAH-XefdwTiyRYuvd5C5QyLX0NPxa3ZRQk&s=F2YcX4M_wpkeFWtlw6oBZaYIXfQ2EDwKRc_xOrI7xK0&e= > > > > > > > > Is there some level of Jira access I can get so I can grab the ticket, > > or > > > > is there another protocol to follow. I was not able to assign the > > ticket > > > > to myself after I created my ASF Jira account (username: donresnik) > > > > > > > > Thanks, > > > > > > > > Don > > > > ________________________________ > > > > From: Christopher <[email protected]> > > > > Sent: Tuesday, April 16, 2019 2:13 PM > > > > To: accumulo-dev > > > > Subject: Re: new committer question > > > > > > > > [External Email] > > > > > > > > ---------------------------------------------------------------------- > > > > Hi Don! Welcome to the community. > > > > > > > > Were you looking on JIRA or GitHub? > > > > We're trying to track new issues on GitHub at > > > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_accumulo_issues&d=DwIFaQ&c=Ff2GokX4A_6S-cy_JRNEiQ&r=7sXp0We1OQQKRSGyjz35VSGU6op68dwzfY3c89DwDgBombhjVkfUnmcvB18wjBra&m=Z5TrAOFD4oAH-XefdwTiyRYuvd5C5QyLX0NPxa3ZRQk&s=x0Dp6qfyi6dOk4DdBm3Mh3S9P_pMw0qwfNbStlhek8g&e= > > > > However, there's a backlog of issues that still exist on > > > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ACCUMULO&d=DwIFaQ&c=Ff2GokX4A_6S-cy_JRNEiQ&r=7sXp0We1OQQKRSGyjz35VSGU6op68dwzfY3c89DwDgBombhjVkfUnmcvB18wjBra&m=Z5TrAOFD4oAH-XefdwTiyRYuvd5C5QyLX0NPxa3ZRQk&s=WqcX-yHKvichfVFOBmwkJfniF5x3ZU_OJfepzaDlY_0&e= > > > > that may still be valid > > > > (uncertain, as most of them are quite old and we're slowly triaging). > > > > Looking there, I found > > > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_ACCUMULO-2D4377&d=DwIFaQ&c=Ff2GokX4A_6S-cy_JRNEiQ&r=7sXp0We1OQQKRSGyjz35VSGU6op68dwzfY3c89DwDgBombhjVkfUnmcvB18wjBra&m=Z5TrAOFD4oAH-XefdwTiyRYuvd5C5QyLX0NPxa3ZRQk&s=F2YcX4M_wpkeFWtlw6oBZaYIXfQ2EDwKRc_xOrI7xK0&e= > > > > that looks like a > > > > really simple starting point, to at least get used to contributing. > > > > > > > > On Mon, Apr 15, 2019 at 8:13 PM Resnik, Donald J > > > > <[email protected]> wrote: > > > > > > > > > > Accumulo devs, > > > > > > > > > > I am interested in starting to contribute to Accumulo. I was > > looking at > > > > the newbie tickets but a lot of them look pretty old so I wanted to > > make > > > > sure they were still relevant before grabbing one. > > > > > > > > > > Any info on specific newbie tickets that would be good to start with > > > > would be appreciated. > > > > > > > > > > Thanks, > > > > > > > > > > Don Resnik > > > > > > > > > > ________________________________ > > > > > > > > > > The preceding message (including attachments) is covered by the > > > > Electronic Communication Privacy Act, 18 U.S.C. sections 2510-2512, is > > > > intended only for the person or entity to which it is addressed, and > > may > > > > contain information that is confidential, protected by attorney-client > > or > > > > other privilege, or otherwise protected from disclosure by law. If you > > are > > > > not the intended recipient, you are hereby notified that any retention, > > > > dissemination, distribution, or copying of this communication is > > strictly > > > > prohibited. Please reply to the sender that you have received the > > message > > > > in error and destroy the original message and all copies. > > > > > > > > ________________________________ > > > > > > > > The preceding message (including attachments) is covered by the > > Electronic > > > > Communication Privacy Act, 18 U.S.C. sections 2510-2512, is intended > > only > > > > for the person or entity to which it is addressed, and may contain > > > > information that is confidential, protected by attorney-client or other > > > > privilege, or otherwise protected from disclosure by law. If you are > > not > > > > the intended recipient, you are hereby notified that any retention, > > > > dissemination, distribution, or copying of this communication is > > strictly > > > > prohibited. Please reply to the sender that you have received the > > message > > > > in error and destroy the original message and all copies. > > > > > > > > > > ________________________________ > > > > > > The preceding message (including attachments) is covered by the > > Electronic Communication Privacy Act, 18 U.S.C. sections 2510-2512, is > > intended only for the person or entity to which it is addressed, and may > > contain information that is confidential, protected by attorney-client or > > other privilege, or otherwise protected from disclosure by law. If you are > > not the intended recipient, you are hereby notified that any retention, > > dissemination, distribution, or copying of this communication is strictly > > prohibited. Please reply to the sender that you have received the message > > in error and destroy the original message and all copies. > >
