[GitHub] activemq-artemis pull request #1853: ARTEMIS-1663 - Add new message count an...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1853#discussion_r166178431
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
 ---
    @@ -1309,4 +1336,68 @@ public void remove() {
           public void close() {
           }
        }
    +
    +
    +   private static class PagePositionSize {
    --- End diff --
    
    Why not just extend PagePosition (saves on objects)


---