[GitHub] activemq-artemis pull request #1853: ARTEMIS-1663 - Add new message count an...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1853#discussion_r166179369
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
 ---
    @@ -161,4 +165,9 @@
         * @throws Exception
         */
        void onDeletePage(Page deletedPage) throws Exception;
    +
    +   AtomicLong getDeliveredCount();
    --- End diff --
    
    not sure would want to expose an atomic outside the object as it allows 
other code to update it unexpectedly, should probably be  primitive and the 
object should return get on the atomic.


---