Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166272476
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1309,4 +1336,68 @@ public void remove() {
public void close() {
}
}
+
+
+ private static class PagePositionSize {
--- End diff --
The reason I didn't extend is because PagePosition has methods like
nextMessage() which increment the message number, etc. If that is called then
the stored size doesn't really make sense anymore as it won't match which is
why I just created a new object.
---
