Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2305#discussion_r217092142
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
 ---
    @@ -223,7 +223,7 @@ private int read(StorageManager storage, ActiveMQBuffer 
fileBuffer, List<PagedMe
     
        public synchronized void write(final PagedMessage message) throws 
Exception {
           if (!file.isOpen()) {
    -         return;
    +         throw new IllegalStateException("can't write to closed file " + 
file);
    --- End diff --
    
    IllegalSTateException is not much better on this context.
    
    
    Do you have a case where this is happening? 
    
    We shouldn't have a case where the file is open and still trying to write 
it.
    
    
    Where do you see it?


---

Reply via email to