[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2305#discussion_r217426008
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
 ---
    @@ -223,7 +223,7 @@ private int read(StorageManager storage, ActiveMQBuffer 
fileBuffer, List<PagedMe
     
        public synchronized void write(final PagedMessage message) throws 
Exception {
           if (!file.isOpen()) {
    -         return;
    +         throw new IllegalStateException("can't write to closed file " + 
file);
    --- End diff --
    
    ok will do. thx.


---