Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2305#discussion_r217242750
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
 ---
    @@ -223,7 +223,7 @@ private int read(StorageManager storage, ActiveMQBuffer 
fileBuffer, List<PagedMe
     
        public synchronized void write(final PagedMessage message) throws 
Exception {
           if (!file.isOpen()) {
    -         return;
    +         throw new IllegalStateException("can't write to closed file " + 
file);
    --- End diff --
    
    This is from https://github.com/hornetq/hornetq/pull/2122 
    (long forgotten by me. But as the pr noted that this causes random failure 
in PagingTest#testExpireLargeMessageOnPaging()).


---

Reply via email to