[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2483#discussion_r244685607
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ---
    @@ -461,8 +462,7 @@ void deleteLargeMessageFile(final LargeServerMessage 
largeServerMessage) throws
              try {
                 if (isReplicated() && replicator.isSynchronizing()) {
                    synchronized (largeMessagesToDelete) {
    --- End diff --
    
    @franz1981 looking at the code, looks like its just vanilla HM 
    
       protected final Map<Long, LargeServerMessage> largeMessagesToDelete = 
new HashMap<>();



---