Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244756852
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -309,16 +309,17 @@ public void run() {
*/
@Override
protected void performCachedLargeMessageDeletes() {
- for (Long largeMsgId : largeMessagesToDelete) {
- SequentialFile msg = createFileForLargeMessage(largeMsgId,
LargeMessageExtension.DURABLE);
+ for (LargeServerMessage largeServerMessage :
largeMessagesToDelete.values()) {
--- End diff --
Calling values actually creates a new List, if you're iterating the
objects, simply call using forEach method on the collection.
---
