Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244686021
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -193,7 +193,7 @@ public static JournalContent getType(byte type) {
protected final Map<SimpleString, PersistedAddressSetting>
mapPersistedAddressSettings = new ConcurrentHashMap<>();
- protected final Set<Long> largeMessagesToDelete = new HashSet<>();
+ protected final Map<Long, LargeServerMessage> largeMessagesToDelete =
new HashMap<>();
--- End diff --
@CNNJYB we have our own
org.apache.activemq.artemis.utils.collections.LongConcurrentHashMap, this
allows it to be concurrent safe, and also means it can be a primitive long.
---
