All seems well in terms of my previous RC1 skim and the small fixups made thereafter for RC2, but to be clear I haven't voted (due to not actually trying things out myself or looking any closer).
Robbie On Wed, 6 Mar 2019, 23:17 Clebert Suconic, <[email protected]> wrote: > @Robbie Gemmel: I will close the vote tomorrow morning. I'm confused > if I have your +1 or not? > > On Wed, Mar 6, 2019 at 10:45 AM michael.andre.pearce > <[email protected]> wrote: > > > > +1 i was able to build this on centos, then build artemis based on > cleberts artemis branch thats in pr and successfully and run a few smoke > tests.I have checked licenses etc and do not spot anything untoward.Sent > from my Samsung Galaxy smartphone. > > -------- Original message --------From: Clebert Suconic < > [email protected]> Date: 06/03/2019 15:35 (GMT+00:00) To: > [email protected] Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 > (RC2) Here you have the release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12345143On > Wed, Mar 6, 2019 at 9:58 AM Clebert Suconic<[email protected]> > wrote:>> @Michael: On validating the release, I have updated the PR to > consume> the release repository.>> > https://github.com/apache/activemq-artemis/pull/2570>> Travis CI should > do the validation now, that the build is running.>>> You can also consume > the native by downloading the branch from the PR.> Everything related to > libaio should work as expected on the branch and> that will consume the > release bits.>>>> On Tue, Mar 5, 2019 at 12:55 PM michael.andre.pearce> < > [email protected]> wrote:> >> > Without sounding silly. > How am i meant to check this?Currently its a lib but as we dont have the > activemq artemis bit removed in master and dependency on it i cannot build > artemis with it and check its behaviour.Do you have a branch in artemis > that we can use that builds based on the dependency?Sent from my Samsung > Galaxy smartphone.> > -------- Original message --------From: Justin > Bertram <[email protected]> Date: 05/03/2019 16:57 (GMT+00:00) To: > [email protected] Subject: Re: [VOTE] ActiveMQ Artemis Native 1.0.0 > (RC2) LGTM+1JustinOn Tue, Mar 5, 2019 at 10:52 AM Gary Tully < > [email protected]> wrote:> +1>> On Mon, 4 Mar 2019 at 01:25, Clebert > Suconic <[email protected]>> wrote:> >> > I would like to propose > an Apache ActiveMQ Artemis Native 1.0.0> > release. This is a second > re-spin.> >> > This is a sub component of ActiveMQ Artemis Native,> >> > > Source distribution can be found here:> >> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/> > >> > Maven repository is here:> >> > https://repository.apache.org/content/repositories/orgapacheactivemq-1179> > >> >> > The source tag:> >> > https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0> > >> >> >> > Notice this is a sub component of ActiveMQ Artemis, and the > release> > notes will be part of the main component. And also, the binary > here is> > distributed through maven.> >> >> > [ ] +1 approve the release > as Apache Artemis 2.4.0> > [ ] +0 no opinion> > [ ] -1 disapprove (and > reason why)> >> >> > Here's my +1> >> >> > --> > Clebert Suconic>>>>> --> > Clebert Suconic-- Clebert Suconic > > > > -- > Clebert Suconic >
