Let’s do 3x JIRA and 3x PR’s here is a good idea here so the changes can be incrementally reviewed and merged.
Thanks! Matt Pavlovich > On Apr 14, 2021, at 12:55 PM, Arjun Ray <[email protected]> wrote: > > On Wed, 14 Apr 2021 12:07:54 -0500, you wrote: > > | Would you please create a JIRA for these changes and submit the diffs > | as a PR for review? > > One JIRA, but three sets of diffs, where the first two can be applied > without the third. > > 1. 3 edits for the library build. > 2. 3 edits for the tests build. > 3. Global search-and-replace, s/auto_ptr/unique_ptr/g. > > So how many PR's should there be?
