+1 (non-binding). On Thu, Apr 11, 2019 at 10:50 PM Bas Harenslak < basharens...@godatadriven.com> wrote:
> Hello Airflow community, > > This email calls for a vote to introduce Pylint in the Airflow project. > The vote will last for at least 1 week (April 18th 23:00 CET), and at least > three +1 (binding) votes have been cast. > > After feedback on AIP-6 and discussion on Slack< > https://apache-airflow.slack.com/archives/CCPRP7943/p1554962392081400>, I > propose to vote for adding Pylint<https://pylint.org> to the Airflow > project for static code checking. Pylint complements Flake8 with stricter > rules, detects code smells and is customisable so unnecessary checks can be > ignored. This should benefit the Airflow code base with consistent, > documented code and less errors. > > Note that Pylint 2.0 works with Python 3 only, so if the vote is > successful, it should be introduced after dropping support for Python 2 > (AIRFLOW-4196<https://issues.apache.org/jira/browse/AIRFLOW-4196>). > Note2: to keep the scope as small as possible, I’ll create a separate vote > for Black formatting. > > Cheers, > Bas > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> E: jarek.pot...@polidea.com