Heartily agree with it ! I try always to close the PRs but sometimes I got distracted and forget to resolve an issue - it happend several times that I recalled it few hours later that I have forgotten to resolve it. I hope it happens rarely - I'd love to know if I was one of the culprits here :). And whenever I noticed some of the PRs are not closed but PR is merged by someone else - I sometimes close them. But it's not ideal of course.
However simple it is - I think we are just humans and we will forget from time to time. I was wondering if we can (yes, you guessed it) automate it :). Either with JIRA/Github integration or some automated tool to do it regularly and resolving all already merged tickets. And the more committers we are going to have, the more it makes sense to automate some of the work. The less you have to remember about your "chores" the more you can focus on the "real" stuff. I think there are a few unwritten rules that we have - like what version to set when we cherry-pick change to 1.10* . My understanding is that we should set fixed version to the first unreleased yet 1.10. version. This problem will soon be gone, so maybe it's not worth solving it. There are also some edge cases like bad fixes which got reverted and reapplied but I think other than that the automation of it can be rather simple. And I think there are some scripts in "dev" that already do some of that - synchronising merges with JIRAs (but I don't think it's common knowledge and it's not regularly run). Maybe we can improve it somehow and have it fully automated so that we do not even havet to think about it ? WDYT? Any ideas? J. On Sat, Nov 16, 2019 at 1:19 AM Kaxil Naik <[email protected]> wrote: > We have some at > https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide > > The person who merges the PR to master is the one who would be responsible > for resolving the JIRA issue as they can add the *target version* based on > what they think after reviewing the PR. > > On Sat, Nov 16, 2019 at 12:12 AM Aizhamal Nurmamat kyzy < > [email protected]> > wrote: > > > I think it will be good to document the process. For example, who is > > responsible for closing Jira issues: folks who closed PR's or the ones > who > > opened? > > > > If the documentation already exists, let's bring it back to attention. > > > > On Fri, Nov 15, 2019 at 4:06 PM Kaxil Naik <[email protected]> wrote: > > > > > Hi Committers, > > > > > > Please make sure to close the Jira issues if the related PRs are > merged. > > > > > > I am going through the Jira Reports (Image: https://imgur.com/n50Ticx) > > and > > > was concerned with the gap between issues created & resolved in recent > > > months. > > > > > > However, I noticed while going through the jira issues that most of the > > PRs > > > related to the JIRAs have been resolved but the JIRA is not resolved. > > > > > > Let's try to resolve all the issues when we merge the PR :) > > > > > > This will help the release manager too. > > > > > > Regards, > > > Kaxil > > > > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
