Hi all I did some thinking about this and how we can improve the contribution process. Hadn't had a chance to draft that mail yet but some of it is relevant to probot so I'll just reply here :)
I think we already have probot stale (at least, I saw some bot comments on older PRs). I'd suggest we make it a bit more aggressive, looks like it currently comments after 6 months of inactivity which is very long. By then nobody knows the state of the pr. It would also be cool if it could comment after eg 10days to remind the contributor to follow up for code review. I did some analysis and one of the common things holding back PRs from merging is just that review is not requested, then the pr eventually gets too stale to merge. I think this could really help to get more contributions merged. Kind regards On Fri, 20 Dec 2019, 04:02 Daniel Imberman, <daniel.imber...@gmail.com> wrote: > +1 +1 +1 +1 > +1 +1 +1 +1 > +1 +1 +1 +1 > +1 +1 +1 +1 > +1 +1 +1 +1 > +1 +1 +1 +1 > +1 +1 +1 +1 > … > > Yes please. > > > via Newton Mail [ > https://cloudmagic.com/k/d/mailapp?ct=dx&cv=10.0.32&pv=10.14.5&source=email_footer_2 > ] > On Thu, Dec 19, 2019 at 5:51 PM, Kaxil Naik <kaxiln...@gmail.com> wrote: > Hello all, > > I would like to propose that we add the following ProBot integrations to > Airflow repo: > > - https://github.com/apps/ci-reporter - Works with your project's CI > tool to report failed builds into the relevant PR. > - https://github.com/apps/mergeable - Prevents merging of Pull Requests > based on configurations. Make your Pull Requests mergeable only when: > - https://github.com/apps/wip/ - Prevent merging of WIP PRs > - https://github.com/apps/stale/ - Closes abandoned issues after a > period of inactivity. > > > We can add more integrations later but for now, I propose we add the above > 4. If we have a positive consensus I will raise a JIRA issue with the > Apache INFRA team. > > Regards, > Kaxil
