+1 On Tue, 21 Dec 2021 at 16:19, Elad Kalif <elad...@apache.org> wrote:
> +1 > > On Tue, Dec 21, 2021 at 4:02 PM Ash Berlin-Taylor <a...@apache.org> wrote: > >> +1 >> >> On 21 December 2021 13:41:53 GMT, Jarek Potiuk <ja...@potiuk.com> wrote: >>> >>> Following the discussion in >>> https://github.com/apache/airflow/pull/20238#issuecomment-998780796 >>> >>> Should we completely remove tests and python2 binary with Python 2 >>> from the reference image? >>> >>> We still keep Python 2 installed in our Reference Images and we have >>> tests in our CI that test that Python 2 works for PythonVirtualenv >>> https://github.com/apache/airflow/blob/ee87953652e1bea103aa1b338293306eb7ae041d/tests/operators/test_python.py#L820 >>> >>> We also advise our users >>> https://airflow.apache.org/docs/apache-airflow/stable/upgrading-from-1-10/index.html#step-1-switch-to-python-3 >>> to use PythonVirtualenvOperator if they still want to run Python 2. >>> >>> It's 2 years after the end of life for Python 2 in January. >>> >>> My proposal is to finally put Python 2 to rest for our images and >>> tests. This does not mean that people won't be able to use it if they >>> REALLY want to. They will be able to - it's just our advise will be >>> that they move to Python 3 (or use custom Kubernetes POD Operator with >>> Python2 installed) and we remove it from both - test and reference >>> image so there is no guarantee it's going to work with Python >>> Virtualenv. >>> >>> Is there anyone who thinks it's a bad idea ? If I do not see any >>> strong opposition, I will ask for a lazy consensus in a few days. >>> >>> "Speak now or forever hold your peace" ;) >>> >>> J. >>> >>>