+1 for #36537. Shubham
On 2024-01-23, 3:03 PM, "Scheffler Jens (XC-AS/EAE-ADA-T)" <jens.scheff...@de.bosch.com.inva <mailto:jens.scheff...@de.bosch.com.inva>LID> wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur externe. Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne pouvez pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain que le contenu ne présente aucun risque. +1 for #22253 as I favor contributions from non-committers - but also high respect for Jareks PR #36537 which was a great step! W/o putting 22253 on the plate I would habe voted for 36537 Sent from Outlook for iOS<https://aka.ms/o0ukef> <https://aka.ms/o0ukef>> ________________________________ From: Hussein Awala <huss...@awala.fr <mailto:huss...@awala.fr>> Sent: Tuesday, January 23, 2024 9:12 PM To: dev@airflow.apache.org <mailto:dev@airflow.apache.org> <dev@airflow.apache.org <mailto:dev@airflow.apache.org>> Subject: Re: [VOTE] January 2024 PR of the Month +1 for #36537 On Tue, Jan 23, 2024 at 3:40 PM Andrey Anshin <andrey.ans...@taragol.is <mailto:andrey.ans...@taragol.is>> wrote: > My vote goes to #36537. > But I think we should mention PR #22253 as a PR which finally merged - > "keep calm and add changes" > > > On Tue, 23 Jan 2024 at 17:36, Wei Lee <weilee...@gmail.com > <mailto:weilee...@gmail.com>> wrote: > > > My vote is for #36537. Love this packaging improvement! > > > > Best, > > Wei > > > > > On Jan 23, 2024, at 10:30 PM, Ryan Hatter <ryan.hat...@astronomer.io > > > <mailto:ryan.hat...@astronomer.io> > .INVALID> > > wrote: > > > > > > Gotta agree with Constance and go with 22253 -- how cool that the > author > > > stuck with it all this time! > > > > > > On Tue, Jan 23, 2024 at 12:25 AM Aritra Basu <aritrabasu1...@gmail.com > > > <mailto:aritrabasu1...@gmail.com> > > > > > wrote: > > > > > >> My vote is for #36537 it's been a huge effort and it makes huge > > >> improvements in our packaging. Great to see it make it into airflow. > > >> > > >> -- > > >> Regards, > > >> Aritra Basu > > >> > > >> On Tue, Jan 23, 2024, 10:13 AM Amogh Desai <amoghdesai....@gmail.com > > >> <mailto:amoghdesai....@gmail.com>> > > >> wrote: > > >> > > >>> Is there a possibility to vote for more than one? I guess not :/ > > >>> > > >>> My vote goes to #36537 for the enhancements that have come in with > it. > > I > > >>> have followed the discussions > > >>> at a higher level and it surely wasn't easy :) > > >>> (If I could vote again, it would surely be #36537 for the endless > > >>> perseverance and dedication of the author) > > >>> > > >>> Thanks & Regards, > > >>> Amogh Desai > > >>> > > >>> On Tue, Jan 23, 2024 at 3:21 AM Jarek Potiuk <ja...@potiuk.com > > >>> <mailto:ja...@potiuk.com>> > wrote: > > >>> > > >>>> Heck, why not. I will shamelessly vote on my #36537. While it took > > >> just a > > >>>> few weeks to merge, It leapfrogged our legacy packaging setup to > > >>>> more-or-less bleeding edge from what was there since the beginning > of > > >>>> Airflow (almost 10 years) and was already "old-ish" when I joined > the > > >>>> project more than 4 years ago. And with hatch and cleanups in > extras, > > >> it > > >>>> has a positive impact on both - contributors and users (or so I > hope). > > >>>> > > >>>> On Mon, Jan 22, 2024 at 7:48 PM Constance Martineau > > >>>> <consta...@astronomer.io.inva > > >>>> <mailto:consta...@astronomer.io.inva>lid> wrote: > > >>>> > > >>>>> +1 #22253 > > >>>>> > > >>>>> The PR was opened in March 2022, and was finally merged last week! > I > > >>>> admire > > >>>>> the author's persistence in getting this merged in, and think the > > >>>>> simplifications to the interface make the Operator more > user-friendly > > >>> for > > >>>>> our Data Science users. > > >>>>> > > >>>>> On Mon, Jan 22, 2024 at 1:29 PM Briana Okyere > > >>>>> <briana.oky...@astronomer.io.inva > > >>>>> <mailto:briana.oky...@astronomer.io.inva>lid> wrote: > > >>>>> > > >>>>>> Hey All, > > >>>>>> > > >>>>>> It’s once again time to vote for the PR of the Month. > > >>>>>> > > >>>>>> With the help of the `get_important_pr_candidates` script in > > >>> dev/stats, > > >>>>>> we've identified the following candidates: > > >>>>>> > > >>>>>> PR #36513: Include plugins in the architecture diagrams. > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F36513&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529942893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WQtsV5hGHG7lmJS29WGirgwRixjAsDehx0TlawHrMbE%3D&reserved=0<https://github.com/apache/airflow/pull/36513>> > > >>>>>> > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F36513&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529942893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WQtsV5hGHG7lmJS29WGirgwRixjAsDehx0TlawHrMbE%3D&reserved=0<https://github.com/apache/airflow/pull/36513>>> > > >>>>>> > > >>>>>> PR #32867: Sanitize the conn_id to disallow potential script > > >>>> execution. < > > >>>>>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F32867&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529951839%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GyrZq5CqumGDckYlViWlIykCqLNW9XTa3Zuo7g6bqmE%3D&reserved=0><https://github.com/apache/airflow/pull/32867> > > >>>>>> > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F32867&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529951839%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GyrZq5CqumGDckYlViWlIykCqLNW9XTa3Zuo7g6bqmE%3D&reserved=0><https://github.com/apache/airflow/pull/32867>> > > >>>>>> > > >>>>>> PR #22253: Add SparkKubernetesOperator crd implementation. > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F22253&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529956937%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3bHd7PJZIad6QOR0Okf29zy9U50DvTqeGFEgpQniS08%3D&reserved=0<https://github.com/apache/airflow/pull/22253>> > > >>>>>> > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F22253&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529956937%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3bHd7PJZIad6QOR0Okf29zy9U50DvTqeGFEgpQniS08%3D&reserved=0<https://github.com/apache/airflow/pull/22253>>> > > >>>>>> > > >>>>>> PR #36171: Implement AthenaSQLHook. > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F36171&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529961013%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=F8RZKmJF7xZi7Goh0dXonf1oW45V%2BWM%2Ftz4Yjq2fJg0%3D&reserved=0<https://github.com/apache/airflow/pull/36171>> > > >>>>>> > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F36171&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529961013%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=F8RZKmJF7xZi7Goh0dXonf1oW45V%2BWM%2Ftz4Yjq2fJg0%3D&reserved=0<https://github.com/apache/airflow/pull/36171>>> > > >>>>>> > > >>>>>> PR #36537: Standardize airflow build process and switch to > > >> Hatchling > > >>>>> build > > >>>>>> backend. > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F36537&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529964965%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ra%2FSOXwuggtKjwQyL5SWEzKW%2BSjvOwK5WT%2BSI3hh8F4%3D&reserved=0<https://github.com/apache/airflow/pull/36537>> > > >>>>>> > > >>>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F36537&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529964965%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ra%2FSOXwuggtKjwQyL5SWEzKW%2BSjvOwK5WT%2BSI3hh8F4%3D&reserved=0<https://github.com/apache/airflow/pull/36537>>> > > >>>>>> > > >>>>>> Please reply to this thread with your selection or offer your own > > >>>>>> nominee(s). > > >>>>>> > > >>>>>> Voting will close on Jan. 26th at 1 PM PST. The winner(s) will be > > >>>>> featured > > >>>>>> in the next issue of the Airflow newsletter. > > >>>>>> > > >>>>>> Also, if there’s an article or event that you think should be > > >>> included > > >>>> in > > >>>>>> this or a future issue of the newsletter, please drop me a line at > > >> < > > >>>>>> briana.oky...@astronomer.io <mailto:briana.oky...@astronomer.io>>. > > >>>>>> > > >>>>>> -- > > >>>>>> Briana Okyere > > >>>>>> Community Manager > > >>>>>> *Astronomer* > > >>>>>> > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> > > >>>>> Constance Martineau > > >>>>> Senior Product Manager > > >>>>> > > >>>>> Email: consta...@astronomer.io <mailto:consta...@astronomer.io> > > >>>>> Time zone: US Eastern (EST UTC-5 / EDT UTC-4) > > >>>>> > > >>>>> > > >>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.astronomer.io%2F&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529968848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aDxBeBMwRCt0l6j%2BZzlR4LMsQna5PxUFMaBdO4dPx7k%3D&reserved=0<https://www.astronomer.io/>> > > >>>>> > > >>>>> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.astronomer.io%2F&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cd9c921e8717247c6a5a808dc1c4fa154%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638416375529968848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aDxBeBMwRCt0l6j%2BZzlR4LMsQna5PxUFMaBdO4dPx7k%3D&reserved=0<https://www.astronomer.io/>>> > > >>>>> > > >>>> > > >>> > > >> > > > > >
