sjyangkevin commented on code in PR #55457: URL: https://github.com/apache/airflow/pull/55457#discussion_r2338449479
########## providers/weaviate/tests/unit/weaviate/hooks/test_weaviate.py: ########## Review Comment: thanks for the fix. wondering if it would be better to have one parameterized test case to specifically test for this port configuration. For example, if port is not specified and http_secure is False, then 80 if port is not specified and http_secure is True, then 443 if port is set to 8000 and http_secure is False, then 8000 etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
