Ahh, tested the build on a fresh virtualenv, which succeeded *the first time* given gitpython was not installed and it skipped the assertion check <https://github.com/apache/incubator-airflow/blob/1.9.0rc8/setup.py#L68-L73>. Build fails on re-installs :(
On Fri, Dec 15, 2017 at 6:01 PM, Feng Lu <fen...@google.com.invalid> wrote: > +0.5 (non-binding) > > Looks like the version(1.9.0) and tag(1.9.0rc8) is mismatched, > <https://github.com/apache/incubator-airflow/blob/1.9.0rc8/setup.py#L87> > which will cause the installation (pip install or python setup) to error > out and fail. > nit: mind also updating the release log " > https://github.com/apache/incubator-airflow/blob/1.9.0rc8/CHANGELOG.txt"; > > > On Fri, Dec 15, 2017 at 3:21 PM, Driesprong, Fokko <fo...@driesprong.frl> > wrote: > > > +1 binding > > > > Op vr 15 dec. 2017 om 23:39 schreef Bolke de Bruin <bdbr...@gmail.com> > > > > > +1, binding > > > > > > Checked sigs, version, source is there (did not check build), bin is > > there. > > > > > > Bolke > > > > > > Verstuurd vanaf mijn iPad > > > > > > > Op 15 dec. 2017 om 23:31 heeft Joy Gao <j...@wepay.com> het volgende > > > geschreven: > > > > > > > > +1, binding > > > > > > > > Thank you Chris! > > > > > > > > On Fri, Dec 15, 2017 at 2:30 PM, Chris Riccomini < > > criccom...@apache.org> > > > > wrote: > > > > > > > >> Hey all, > > > >> > > > >> (Last time, I hope)^2 > > > >> > > > >> I have cut Airflow 1.9.0 RC8. This email is calling a vote on the > > > release, > > > >> which will last for 72 hours. Consider this my (binding) +1. > > > >> > > > >> Airflow 1.9.0 RC8 is available at: > > > >> > > > >> https://dist.apache.org/repos/dist/dev/incubator/airflow/1.9.0rc8/ > > > >> > > > >> apache-airflow-1.9.0rc8+incubating-source.tar.gz is a source > release > > > that > > > >> comes with INSTALL instructions. > > > >> apache-airflow-1.9.0rc8+incubating-bin.tar.gz is the binary Python > > > "sdist" > > > >> release. > > > >> > > > >> Public keys are available at: > > > >> > > > >> https://dist.apache.org/repos/dist/release/incubator/airflow/ > > > >> > > > >> The release contains no new JIRAs. Just a version fix. > > > >> > > > >> I also had to change the version number to exclude the `rc6` string > as > > > well > > > >> as the "+incubating" string, so it's now simply 1.9.0. This will > allow > > > us > > > >> to rename the artifact without modifying the artifact checksums when > > we > > > >> actually release. > > > >> > > > >> See JIRAs that were in 1.9.0RC7 and before (see previous VOTE email > > for > > > >> full list). > > > >> > > > >> Cheers, > > > >> Chris > > > >> > > > > > >
