> On Feb. 3, 2015, 6:32 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java, > > line 308 > > <https://reviews.apache.org/r/30568/diff/1/?file=845792#file845792line308> > > > > This typically happens while all services are stopped and no agents are > > heartbeating. Wouldn't the task fail? > > Yurii Shylov wrote: > As the server is down at the moment of upgrade, the actions are just > stored in PENDING state in database and are executed only after the server > starts. > It was working with previous implementation (not sure, maybe due to small > cluster of HDFS only the hearbeat was ariving before the comand execution was > scheduled) but after switching to AmbariCustomCommandExecutionHelper it > really rejects to launch command, I'm looking for a way to avoid this. > > Yurii Shylov wrote: > I'm going to change this the following way: response for Register command > will emit new event like HostRegisterComplete. There will be subscriber for > the event which will request component version only from the host which was > just registered
So the underlying problem is that for components (typically clients) that only advertise the version on INSTALL, an existing cluster with those components already installed will have no way of knowing what the version for those components is. One potential solution is to initiate a status command on the agent that will return the version, so that the heartbeat handler can take care of the rest. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review70784 ----------------------------------------------------------- On Feb. 4, 2015, 6:24 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 6:24 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > Current implementation schedules request to every component to get its > version after server upgrade 1.7.0 - 2.0.0 was completed. It creates a stage > per every component and thus looks ugly. I'm in the process of rewriting it > to use AmbariCustomCommandExecutionHelper to call > save_component_version_to_structured_out() directly for every component. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 683397a > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > b8f3cd7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java > 35f9db5 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java > 8a9799d > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > a83d26d > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > preview > > > Thanks, > > Yurii Shylov > >
