> On Feb. 9, 2015, 6:44 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 213 > > <https://reviews.apache.org/r/30568/diff/3/?file=858782#file858782line213> > > > > the method() should be called before the call to > > save_component_version_to_structured_out, because the actual method call > > can be the start that actually calls hdp-slect. > > Yurii Shylov wrote: > The problem is that client components throw exception on calling > status(), so they won't advertise their version if I move code after > method(env)
In that case, make sure that method = self.choose_method_to_execute() returns an object. If it raises NonImplemented exception, then write one out for zookeeper-server that does nothing. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review71663 ----------------------------------------------------------- On Feb. 9, 2015, 6:29 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 6:29 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > During the upgrade process, populate the repo_version, cluster_version, and > host_version tables. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 683397a > > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java > a71bbd1 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 80ef542 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 4fe219c > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > preview > > > Thanks, > > Yurii Shylov > >
