----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review71679 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/script/script.py <https://reviews.apache.org/r/30568/#comment117543> You could probably use a finally: block as part of the try: method(env) below. sys.exit() raises an error that is honored by a try/finally (os._exit() does not). ambari-common/src/main/python/resource_management/libraries/script/script.py <https://reviews.apache.org/r/30568/#comment117544> Can use a finally block to check for version-setting in structuredOut. - Nate Cole On Feb. 9, 2015, 1:29 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 1:29 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > During the upgrade process, populate the repo_version, cluster_version, and > host_version tables. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 683397a > > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java > a71bbd1 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 80ef542 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 4fe219c > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > preview > > > Thanks, > > Yurii Shylov > >
