----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38065/#review97623 -----------------------------------------------------------
I think I need to make some modifications to the cluster name logic. will upload another patch. - Jonathan Maron On Sept. 2, 2015, 7:36 p.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38065/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 7:36 p.m.) > > > Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-12978 > https://issues.apache.org/jira/browse/AMBARI-12978 > > > Repository: ambari > > > Description > ------- > > Rather than make modifications that are not visible to the user via the > service scripts, the config changes that are required for hive when atlas is > available in the cluster have been moved to the stack advisor. Some > important points: > > 1) atlas.cluster.name and atlas.rest.address are now configuration > properties that are defined in the service's hive-site.xml. They therefore > appear as advanced hive-site properties in the UI. > 2) When atlas is not installed, these two properties are set to a space so > that hopefully no values are seen in the UI and the 'require-input' attribute > of atlas.cluster.name does not trigger a requirement to specify a value. > 3) When atlas is installed, the atlas.cluster.name is set to a null string > and the 'require-input' property appears to trigger the expected "value > required" logic in the UI. This is important since the cluster name property > defines the namespace for the atlas queries associated with the given cluster > (atlas supports multiple hive instances). > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > f4e4b25 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > a5abcb5 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 2d07726 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 08c48d8 > > Diff: https://reviews.apache.org/r/38065/diff/ > > > Testing > ------- > > - python unit tests > - installation of clusters: > 1) Hive only followed by addition of atlas > 2) hive and atlas together > > (NOTE: still working thru some of the functional cluster test scenarios but > wanted to proceed with a review process in parallel) > > > Thanks, > > Jonathan Maron > >
