> On Sept. 11, 2015, 6:15 a.m., Srimanth Gunturi wrote:
> > To make add-service wizard change configs in Hive also I had to add the 
> > extra depends-on in 'hive.exec.pre.hooks'
> > 
> >  <property>
> >     <name>hive.exec.pre.hooks</name>
> >     <value>org.apache.hadoop.hive.ql.hooks.ATSHook</value>
> >     <description>
> >       Comma-separated list of pre-execution hooks to be invoked for each 
> > statement.
> >       A pre-execution hook is specified as the name of a Java class which 
> > implements the
> >       org.apache.hadoop.hive.ql.hooks.ExecuteWithHookContext interface.
> >     </description>
> >     <depends-on>
> >       <property>
> >         <type>hive-env</type>
> >         <name>hive_timeline_logging_enabled</name>
> >       </property>
> >     </depends-on>
> >   </property>

<property>
    <name>hive.exec.post.hooks</name>
    <value>org.apache.hadoop.hive.ql.hooks.ATSHook</value>
    <description>
      Comma-separated list of post-execution hooks to be invoked for each 
statement.
      A post-execution hook is specified as the name of a Java class which 
implements the
      org.apache.hadoop.hive.ql.hooks.ExecuteWithHookContext interface.
    </description>
    <depends-on>
      <property>
        <type>hive-env</type>
        <name>hive_timeline_logging_enabled</name>
      </property>
      <property>
        <type>atlast-env</type>
        <name>metadata_port</name>
      </property>
    </depends-on>
  </property>


- Srimanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98564
-----------------------------------------------------------


On Sept. 10, 2015, 9:59 p.m., Jonathan Maron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 9:59 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-12978
>     https://issues.apache.org/jira/browse/AMBARI-12978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Rather than make modifications that are not visible to the user via the 
> service scripts, the config changes that are required for hive when atlas is 
> available in the cluster have been moved to the stack advisor.  Some 
> important points:
> 
> 1)  atlas.cluster.name and atlas.rest.address are now configuration 
> properties that are defined in the service's hive-site.xml.  They therefore 
> appear as advanced hive-site properties in the UI.
> 2)  When atlas is not installed, these two properties are set to a space so 
> that hopefully no values are seen in the UI and the 'require-input' attribute 
> of atlas.cluster.name does not trigger a requirement to specify a value.
> 3)  When atlas is installed, the atlas.cluster.name is set to a null string 
> and the 'require-input' property appears to trigger the expected "value 
> required" logic in the UI.  This is important since the cluster name property 
> defines the namespace for the atlas queries associated with the given cluster 
> (atlas supports multiple hive instances).
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
>  f4e4b25 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  affee98 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> c65e110 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> bea7d60 
> 
> Diff: https://reviews.apache.org/r/38065/diff/
> 
> 
> Testing
> -------
> 
> - python unit tests
> - installation of clusters:
> 1)  Hive only followed by addition of atlas
> 2)  hive and atlas together
> 
> (NOTE:  still working thru some of the functional cluster test scenarios but 
> wanted to proceed with a review process in parallel)
> 
> 
> Thanks,
> 
> Jonathan Maron
> 
>

Reply via email to