----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43743/#review119743 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 198) <https://reviews.apache.org/r/43743/#comment181082> New prop to control the prechecks. ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java (line 69) <https://reviews.apache.org/r/43743/#comment181083> BYPASS implies failed but can be skipped. ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js (line 889) <https://reviews.apache.org/r/43743/#comment181084> I should probably put these in messages.js ambari-web/app/styles/stack_versions.less (line 320) <https://reviews.apache.org/r/43743/#comment181085> Removed the fixed height since it is now dynamic based on the additional error message that can show up. - Alejandro Fernandez On Feb. 18, 2016, 11:10 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43743/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 11:10 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Richard Zang, and Xi Wang. > > > Bugs: AMBARI-13424 > https://issues.apache.org/jira/browse/AMBARI-13424 > > > Repository: ambari > > > Description > ------- > > In some environments, the customer still wants to proceed with RU & EU even > if PreChecks fail. E.g., > NameNode HA doesn't actually exist if they have their own distribution of HDFS > Hosts be down at the time the upgrade is starting, but will come online > during the upgrade. > > Today, they are unable to start RU/EU if any of the PreChecks fail. > Introduce a config in ambari.properties file called > "stack.upgrade.bypass.prechecks" whose default value is "false" > > > Diffs > ----- > > ambari-server/conf/unix/ambari.properties 81ef446 > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 8a81aa9 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > cfc2f51 > ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java > 5a8d4fd > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrereqCheckStatus.java > f8009e3 > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > c226059 > ambari-web/app/messages.js 9d24b4f > ambari-web/app/styles/stack_versions.less ab27a84 > ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs > 8fd2746 > ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs > 268ea1d > ambari-web/app/views/common/modal_popups/cluster_check_popup.js 54f20ba > > Diff: https://reviews.apache.org/r/43743/diff/ > > > Testing > ------- > > Verified on PreChecks for RU/EU when put hosts in maintenance mode and tested > with/without the config "stack.upgrade.bypass.prechecks" > See screenshots in Apache Jira. > > Waiting for unit test results. > > > Thanks, > > Alejandro Fernandez > >
