-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43743/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 2:20 a.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole,
Richard Zang, and Xi Wang.
Changes
-------
Addressed comments. Added unit test that injects the factory for
PrerequisiteCheck
Bugs: AMBARI-13424
https://issues.apache.org/jira/browse/AMBARI-13424
Repository: ambari
Description
-------
In some environments, the customer still wants to proceed with RU & EU even if
PreChecks fail. E.g.,
NameNode HA doesn't actually exist if they have their own distribution of HDFS
Hosts be down at the time the upgrade is starting, but will come online during
the upgrade.
Today, they are unable to start RU/EU if any of the PreChecks fail.
Introduce a config in ambari.properties file called
"stack.upgrade.bypass.prechecks" whose default value is "false"
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
8a81aa9
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
257d575
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
3517537
ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
a47512e
ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
4dfc8e9
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
77a85b9
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
ea20a55
ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
5e7bdef
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
1f1980f
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
eaedd3f
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
30250ef
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
52546d2
ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
06ca162
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
3a4467f
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
33f971a
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
4893098
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
18a5bde
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
3970e9e
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
b7d2417
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
35be754
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
5dadcdd
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
09ad55d
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
77605c1
ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
7071681
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
9dd4877
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
8cb8020
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
cfc2f51
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
76ff6db
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
7d7b618
ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java
5a8d4fd
ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrereqCheckStatus.java
f8009e3
ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrerequisiteCheck.java
5822abd
ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrerequisiteCheckFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrerequisiteCheckFactoryImpl.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrerequisiteCheckImpl.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
5281a1b
ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java
7b8239c
ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java
450d74e
ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java
68a0522
ambari-server/src/test/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheckTest.java
cdf13eb
ambari-server/src/test/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheckTest.java
16f383a
ambari-server/src/test/java/org/apache/ambari/server/checks/HostMaintenanceModeCheckTest.java
0e14376
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java
cc2c276
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java
9fcb319
ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java
4529554
ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
080ca3a
ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java
bfe0c3e
ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java
2005e36
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java
afa3789
ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java
e2617bf
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java
a941b7a
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheckTest.java
22f2b1b
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheckTest.java
abe7abe
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java
87d4167
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheckTest.java
334b3b3
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
88826a0
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheckTest.java
98cfb18
ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
7469bbc
ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java
283a3ca
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js c226059
ambari-web/app/messages.js 9d24b4f
ambari-web/app/styles/stack_versions.less ab27a84
ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs 8fd2746
ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs 268ea1d
ambari-web/app/views/common/modal_popups/cluster_check_popup.js 54f20ba
Diff: https://reviews.apache.org/r/43743/diff/
Testing
-------
Verified on PreChecks for RU/EU when put hosts in maintenance mode and tested
with/without the config "stack.upgrade.bypass.prechecks"
See screenshots in Apache Jira.
Waiting for unit test results.
Thanks,
Alejandro Fernandez
