----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43743/#review119883 -----------------------------------------------------------
UpgradeResourceProvider.validatePreRequest() is also invoking prereq checks. That class is checking directly for FAILED, but if it sees BYPASS, then something should get logged. In terms of scope, this is a pretty important change that should have some tests. And please, don't make a new jira for tests. That's starting to become an annoying practice. ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (lines 1041 - 1043) <https://reviews.apache.org/r/43743/#comment181277> I prefer the isUpgradePrecheckBypass() style, but ok. ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java (lines 67 - 68) <https://reviews.apache.org/r/43743/#comment181280> I would dump it all. The fail reason, the failed hosts, the failed services etc. No need for the "Allowed to bypass" line, as each check (could be 20 of them) will each write this entry. In fact, maybe this is too low a level for this logging. Set the status of BYPASS, but log from the ResourceProvider? ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrereqCheckStatus.java (line 26) <https://reviews.apache.org/r/43743/#comment181275> if it needs to be documented, javadoc it (and the others too i suppose) - Nate Cole On Feb. 18, 2016, 6:10 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43743/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 6:10 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Richard Zang, and Xi Wang. > > > Bugs: AMBARI-13424 > https://issues.apache.org/jira/browse/AMBARI-13424 > > > Repository: ambari > > > Description > ------- > > In some environments, the customer still wants to proceed with RU & EU even > if PreChecks fail. E.g., > NameNode HA doesn't actually exist if they have their own distribution of HDFS > Hosts be down at the time the upgrade is starting, but will come online > during the upgrade. > > Today, they are unable to start RU/EU if any of the PreChecks fail. > Introduce a config in ambari.properties file called > "stack.upgrade.bypass.prechecks" whose default value is "false" > > > Diffs > ----- > > ambari-server/conf/unix/ambari.properties 81ef446 > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 8a81aa9 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > cfc2f51 > ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java > 5a8d4fd > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrereqCheckStatus.java > f8009e3 > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > c226059 > ambari-web/app/messages.js 9d24b4f > ambari-web/app/styles/stack_versions.less ab27a84 > ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs > 8fd2746 > ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs > 268ea1d > ambari-web/app/views/common/modal_popups/cluster_check_popup.js 54f20ba > > Diff: https://reviews.apache.org/r/43743/diff/ > > > Testing > ------- > > Verified on PreChecks for RU/EU when put hosts in maintenance mode and tested > with/without the config "stack.upgrade.bypass.prechecks" > See screenshots in Apache Jira. > > Waiting for unit test results. > > > Thanks, > > Alejandro Fernandez > >
