At 08:18 AM 7/30/2004, David Reid wrote:
>>However, we need to remove the APR_STATUS_IS_SUCCESS macro before 1.0 goes
>>out, because otherwise we are stuck with it for a very long time.
>
>There were win32 comments from Brane? Is someone going to commit the changes
>needed?
What changes? Note in apr_errno :
#define APR_FROM_OS_ERROR(e) (e == 0 ? APR_SUCCESS : e + APR_OS_START_SYSERR)
#define APR_TO_OS_ERROR(e) (e == 0 ? APR_SUCCESS : e - APR_OS_START_SYSERR)
#define apr_get_os_error() (APR_FROM_OS_ERROR(GetLastError()))
#define apr_set_os_error(e) (SetLastError(APR_TO_OS_ERROR(e)))
#define apr_get_netos_error() (APR_FROM_OS_ERROR(WSAGetLastError()))
#define apr_set_netos_error(e) (WSASetLastError(APR_TO_OS_ERROR(e)))
so as you see we already fold 0 : 0
but ... oh my what''s this in the OS2 section???
// XXX deprecated
#define APR_STATUS_IS_ETIMEDOUT(s) ((s) == APR_ETIMEDOUT \
|| (s) == APR_OS_START_SYSERR + SOCETIMEDOUT)
Bad comment form and a left-over deprecation? I'm out of week, but
someone please squish that :-/
Bill
