Hi all I try to do some integration test deploying the new implementation with eclipselink and my test bundle. I make a change on the logic of PersistenceProvider service filter. To be abstract I don't want define the class of implementation in persistence.xml, so in this case I cannot filter using the class name. I found and fix also some minor issues. I open another pull request.
However, I don't make several test (like transaction and so on), but from my point of the new implementation is more easy to manage of actual aries jpa. Regards Giuseppe 2015-04-07 11:54 GMT+02:00 Jean-Baptiste Onofré <j...@nanthrax.net>: > Hi guys, > > Giuseppe, I like your first implementation. I gonna take a deeper look > this afternoon. > > Regards > JB > > > On 04/07/2015 10:23 AM, Giuseppe Gerla wrote: > >> Hi Christian >> I open a pull request with the first implementation. I also add 2 unit >> test. >> It seems an easy implementation. >> Wdyt? >> >> >> >> 2015-04-07 10:21 GMT+02:00 Christian Schneider <ch...@die-schneider.net>: >> >> I am not yet sure how it would be implemented best. I guess you will have >>> to experiment a bit. >>> >>> Why would ManagedEMF need to be a non static class? As far as I know non >>> static classes are only possible as classes inside another class. >>> >>> Christian >>> >>> On 05.04.2015 11:44, Giuseppe Gerla wrote: >>> >>> Yes >>>> It could work... with ManagedService. But ManagedEMF should be changed >>>> in >>>> non static class and should implement ManagedService interface. >>>> Right? >>>> >>>> >>>> >>>> >>> -- >>> Christian Schneider >>> http://www.liquid-reality.de >>> >>> Open Source Architect >>> http://www.talend.com >>> >>> >>> >> > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com >
