Is Arrow C++ the only reusable codebase for that or could the work be
based on e.g. Arrow Rust instead?
I don't know the interoperability story of the Swift language, so there
might be something that favors C++ here.
Regards
Antoine.
Le 11/10/2023 à 02:43, David Li a écrit :
I'm -0 on this without more reasoning. I don't think a large download is a
compelling reason to split the repo, and being in the same repo doesn't mean
you have to take a dependency on the C++ implementation. (Plus, unless there is
enough of a community to replicate all the work done for C++ I suspect you will
want access to Parquet, Dataset, Acero, etc.)
On Tue, Oct 10, 2023, at 17:24, Jacob Wujciak-Jens wrote:
+1 on Dewey's sentiment.
With regards to technicalities:
- a PMC member can create the repo via ASF's gitbox (I assume
'arrow-swift'?)
- the repo then needs to be configured using the '.asf.yaml'
- which merge styles are allowed
- branch protection rules
- to which ml should notifications be sent
- see [1] for more features
- CI
- PR/Issue template
- ...
What is the usual versioning scheme for swift projects and what release
cadence are you planning?
Best
Jacob
On Tue, Oct 10, 2023 at 10:25 PM Dewey Dunnington
<de...@voltrondata.com.invalid> wrote:
Hi Alva,
I would encourage you to do whatever will make life more pleasant for
you and other contributors to the Swift Arrow implementation. I have
found development of an Arrow subproject (nanoarrow) in a separate
repository very pleasant. While I don't run integration tests there,
it's not because of any technical limitation (instead of pulling one
repo in your CI job, just pull two).
For the R bindings to Arrow, which do depend on the C++ bindings, we
do have some benefit because Arrow C++ changes that break R tend to
get fixed by the C++ contributor in their PR, rather than that
responsibility always falling on us. That said, it doesn't happen very
often, and we have informally toyed with the idea of moving out of the
monorepo to make it less intimidating for outside contributors.
Cheers,
-dewey
On Tue, Oct 10, 2023 at 2:33 PM Antoine Pitrou <anto...@python.org> wrote:
Hi Alva,
I'll let others give their opinions on the repo.
Regards
Antoine.
Le 10/10/2023 à 19:25, Alva Bandy a écrit :
Hi Antoine,
Thanks for the reply.
It would be great to get the Swift implementation added to the
integration test. I have a task for adding the C Data Interface and I will
work on getting the integration test running for Swift after that task.
Can we move forward with setting up the repo as long as there is a
task/issue to ensure the integration test will be run against Swift soon or
would this be a blocker?
Also, I am not sure about Julia, I have not looked into Julia’s
implementation.
Thank you,
Alva Bandy
On 2023/10/10 08:54:30 Antoine Pitrou wrote:
Hello Alva,
This is a reasonable request, but it might come with its own drawbacks
as well.
One significant drawback is that adding the Swift implementation to
the
cross-implementation integration tests will be slightly more
complicated.
It is very important that all Arrow implementations are
integration-tested against each other, otherwise we only have a
theoretical guarantee that they are compatible. See how this is done
here:
https://arrow.apache.org/docs/dev/format/Integration.html
Unless I'm mistaken, neither Swift nor Julia are running the
integration
tests.
Regards
Antoine.
Le 09/10/2023 à 22:26, Alva Bandy a écrit :
Hi,
I would like to request a repo for Arrow Swift (similar to
arrow-rs). Swift arrow is currently fully Swift and doesn't leverage the
C++ libraries. One of the goals of Arrow Swift was to provide a fully Swift
impl and splitting them now would help ensure that Swift Arrow stays on
this path.
Also, the Swift Package Manager uses a git repo url to pull down a
package. This can lead to a large download since the entire arrow repo
will be pulled down just to include Arrow Swift. It would be great to make
this change before registering Swift Arrow with a Swift registry (such as
Swift Package Registry).
Please let me know if this is possible and if so, what would be the
process going forward.
Thank you,
Alva Bandy
