Yingyi Bu has posted comments on this change. Change subject: Allow lazy loading for persistent local resources ......................................................................
Patch Set 5: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: Line 48: private final Cache<String, LocalResource> resourcesCache; > I'm not sure if we have a naming standard. I think resourcesCache is better OK, fine for me. (though in many other places in the codebase, we usually use singular for attributive nouns). Line 205: public HashMap<Long, LocalResource> loadAndGetAllResources() throws HyracksDataException { > RecoveryManager needs to have the complete map to use it during recovery. In my opinion, a disk-access-transparent ResourceCache would serve the same purpose. If a lookup hit the cache, just return the resource; otherwise, read the resource from disk and invalidate another cache line. The purpose for this change is for the situation that there are ~1M datasets in AsterixDB. But if we load everything here into the map, we probably will run into the same memory issue. -- To view, visit https://asterix-gerrit.ics.uci.edu/344 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
